chore: add v4 chunk format to chunks-inspect tool #13057
+129
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
commented
May 28, 2024
|
Did the same in #11506. |
|
@agebhar1's PR is merged so I'm going to close this |
slim-bean
added a commit
that referenced
this pull request
Dec 13, 2024
…'clean room' implementation able to decode chunks without importing any Loki code, this update undid that implementation and we would prefer to keep it as a "clean room" type application Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean
force-pushed
the
chunks-inspect-v4
branch
from
ff8665b to
b8c7f51
Compare
|
re-opening this PR after reverting the other implementation, it's preferable that this tool does not import any Loki code to decompress chunks, rather it's able to do so by implementing the chunk format directly |
Comment on lines
+183
to
+184
| //expCRC := binary.BigEndian.Uint32(data[structuredMetadataOffset+structuredMetadataLength:]) | ||
| //computedMetaChecksum := crc32.Checksum(lb, castagnoliTable) |
There was a problem hiding this comment.
Commented code, looks like a left over
|
|
||
| structuredMetadata := data[structuredMetadataOffset : structuredMetadataOffset+structuredMetadataLength] | ||
|
|
||
| // Structured Metadata is "normalized" or "compressed" by storing an index to a string with each log line, and then all the strings in the chunk metadata section |
There was a problem hiding this comment.
nit: By reading the code not sure I understand the "normalized" part of this comment, but maybe I'm just missing context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The chunks-inspect tool was never updated to parse the newer v4 chunk with structured metadata, this PR fixes that
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR